Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: convert to TS #600

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

webwarrior-ws
Copy link
Contributor

Convert tests to Typescript. Update CI workflow to install types/mocha package used by tests.

Convert tests to Typescript. Update CI workflow to install
types/mocha package used by tests.
Mention using TypeScript in "Coding standards" section and
add guideline on "any" type.
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! LGTM

@grunch grunch merged commit 0c4d15a into lnp2pBot:main Oct 23, 2024
4 checks passed
@grunch
Copy link
Member

grunch commented Oct 23, 2024

Hi @webwarrior-ws can you add a lightning invoice with an amount of 100000 sats as a comment on this PR? thanks for your contribution

@webwarrior-ws
Copy link
Contributor Author

lnbc1m1pn3jr9xpp5e2r6dzwe8dc8lwkxtale7stequkunxmjkm5t0hvrtgmtnk0ydx8qcqpjsp50rwlqv6srj0sn4ur92gwhqcgym2qvf0jzqat490dna5jeqx4w3hq9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqdqqmqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcll6lyxlsu4fuhqqqqqlgqqqqqeqqjqtraghq3ex2n5tusm8pzjylmt4raaewzaq2z6tt7kj5mxmkmg85mnrhv6sgy8swk2ca2svfh2zqh5cdqvm27ahvhwvym9epgkd080n2qq03qckv

@grunch
Copy link
Member

grunch commented Oct 24, 2024

lnbc1m1pn3jr9xpp5e2r6dzwe8dc8lwkxtale7stequkunxmjkm5t0hvrtgmtnk0ydx8qcqpjsp50rwlqv6srj0sn4ur92gwhqcgym2qvf0jzqat490dna5jeqx4w3hq9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqdqqmqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcll6lyxlsu4fuhqqqqqlgqqqqqeqqjqtraghq3ex2n5tusm8pzjylmt4raaewzaq2z6tt7kj5mxmkmg85mnrhv6sgy8swk2ca2svfh2zqh5cdqvm27ahvhwvym9epgkd080n2qq03qckv

The payment is failing, please give it a look to these last comments here, as he was using also phoenix wallet

@webwarrior-ws
Copy link
Contributor Author

lnbc1m1pnnxwxnpp5rml03nlyrxgyv0gh8agl424ne2f8y7awcvysln6fkvxlxj8578kqdqhfdexz6m9dcsygetsdaekjaqcqzysxqrrsssp5ux3gl8eqc0ytlu4kf49kjjjplmn9vh3hmtt5aqqdkhn4dwatznqq9qyyssqnwnf3g2p39ae3l35wkunw09vpldw06e2vc6knmy8drnjlmrh0pjsas3nuzvuty55t6seh00wevkzw875d3xy7gwy5cxmj2sywv8aurqpl30kkl

@grunch
Copy link
Member

grunch commented Nov 12, 2024

lnbc1m1pnnxwxnpp5rml03nlyrxgyv0gh8agl424ne2f8y7awcvysln6fkvxlxj8578kqdqhfdexz6m9dcsygetsdaekjaqcqzysxqrrsssp5ux3gl8eqc0ytlu4kf49kjjjplmn9vh3hmtt5aqqdkhn4dwatznqq9qyyssqnwnf3g2p39ae3l35wkunw09vpldw06e2vc6knmy8drnjlmrh0pjsas3nuzvuty55t6seh00wevkzw875d3xy7gwy5cxmj2sywv8aurqpl30kkl

invoice expired. Valid until 2024-11-12 12:15:31 +0000 UTC

@webwarrior-ws
Copy link
Contributor Author

My first invoice was from Phoenix, my second was from Kraken. Would a “reusable QR code” (as named by Phoenix wallet) work? If yes, here it is:

lno1zrxq8pjw7qjlm68mtp7e3yvxee4y5xrgjhhyf2fxhlphpckrvevh50u0q2wakhvmc6crh3me6a0tfqdefplqq9pk6rkny7crhhgswyc6ve326qsrkmcq89hxyj3yf5c8u9a3rp2hact2yu5sne6aylet5k7ah5wgd29qqve2fwtuh8fcj89c83alr6sqllr9kqlf6n7axz3yfqzw0fux8dgmqqgdyc2l2fq5flanc2mkamlqds0j8mrxqw5ydeef37mqvt9fqgkj34mysyd7xdcvzc7make4ljvn5kak0wglqqqs2cqqznh6tdgkky3gndl8v2772y

@grunch
Copy link
Member

grunch commented Nov 19, 2024

My first invoice was from Phoenix, my second was from Kraken. Would a “reusable QR code” (as named by Phoenix wallet) work? If yes, here it is:

lno1zrxq8pjw7qjlm68mtp7e3yvxee4y5xrgjhhyf2fxhlphpckrvevh50u0q2wakhvmc6crh3me6a0tfqdefplqq9pk6rkny7crhhgswyc6ve326qsrkmcq89hxyj3yf5c8u9a3rp2hact2yu5sne6aylet5k7ah5wgd29qqve2fwtuh8fcj89c83alr6sqllr9kqlf6n7axz3yfqzw0fux8dgmqqgdyc2l2fq5flanc2mkamlqds0j8mrxqw5ydeef37mqvt9fqgkj34mysyd7xdcvzc7make4ljvn5kak0wglqqqs2cqqznh6tdgkky3gndl8v2772y

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants